Skip to content

fix: tags_to_maps/2 invalid tags filtering out#719

Open
charmful0x wants to merge 1 commit intoneo/edgefrom
fix/hbmaps-json-iface
Open

fix: tags_to_maps/2 invalid tags filtering out#719
charmful0x wants to merge 1 commit intoneo/edgefrom
fix/hbmaps-json-iface

Conversation

@charmful0x
Copy link

small patch fixing hb_maps:get/4 default passing, then filtering out not_found tags instead of passing Opts as possible name/value

@samcamwilliams
Copy link
Collaborator

Thanks, but are there any circumstances in which that should actually occur at that point in the code? In this case I guess this is why we didn't see Opts injected into tags anywhere in the system 😄. Perhaps hb_util:ok(hb_maps:find(...)) instead, so that we throw on error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants