fix: hb_store_gateway:remote_hyperbeam_node_ans104_test flaky test#736
Open
speeddragon wants to merge 1 commit intoedgefrom
Open
fix: hb_store_gateway:remote_hyperbeam_node_ans104_test flaky test#736speeddragon wants to merge 1 commit intoedgefrom
speeddragon wants to merge 1 commit intoedgefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the following test command can generate a flaky test when in the list of commitments, the order is different from
ans104,httpsig.HB_PRINT=hb_gateway_client,dev_query_graphql,http_client_short,http_server_short,warning rebar3 eunit --test hb_store_gateway:remote_hyperbeam_node_ans104_testSince we match on the first commitment of the list, if httpsig is the first item will return the HMAC signature.
HyperBEAM/src/ar_bundles.erl
Line 139 in 77b398f
eDAf0cyPL8svRojdP8HyCaBpvxG5ae_33xM3gfLRw9k) and not a valid ar_bundles signature.I've applied the same logic of the owner field below, to ensure that we select the commitment with a commiter (httpsig commitment doesn't have
commiterfield).