Skip to content

fix: dev_mint_index audit #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charmful0x wants to merge 2 commits into
base: impr/secure-actions
Choose a base branch
from
+9 −3
Open

fix: dev_mint_index audit #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6add8c5
fix: withdraw qty double negation
charmful0x Mar 10, 2026
2b01deb
fix: inverted must_delegate check
charmful0x Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/dev_mint_index.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,14 @@ parse_signal(Base, Assignment, Opts) ->
),
{ok, Quantity} ?=
case hb_maps:find(<<"x-action">>, Msg, Opts) of
{ok, <<"deposit">>} -> {ok, RawQuantity};
{ok, <<"withdraw">>} -> {ok, -RawQuantity};
{ok, <<"deposit">>} when is_integer(RawQuantity), RawQuantity >= 0 ->
{ok, RawQuantity};
{ok, <<"deposit">>} ->
{error, <<"Deposit quantity must be a non-negative integer.">>};
{ok, <<"withdraw">>} when is_integer(RawQuantity), RawQuantity =< 0 ->
{ok, RawQuantity};
{ok, <<"withdraw">>} ->
{error, <<"Withdraw quantity must be a non-positive integer.">>};
{ok, _Unsupported} ->
{error, <<"Notification `action' unsupported.">>};
error ->
Expand Down Expand Up @@ -234,7 +240,7 @@ update_model(Address, Quantity, Base, Opts) ->
must_redelegate(Base, _Quantity, _Address, Opts) ->
UpdateEvery = hb_ao:get(<<"update-every">>, Base, 0, Opts),
ChangesSinceUpdate = hb_ao:get(<<"changes-since-update">>, Base, 0, Opts),
UpdateEvery >= ChangesSinceUpdate.
ChangesSinceUpdate >= UpdateEvery.

%% @doc Send messages reflecting updated delegation preferences to the parent
%% mint.
Expand Down