Skip to content

fix(cu/hb): fix slot increment string concat and remove dryRun body guard #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atticusofsparta wants to merge 1 commit into
base: feat/hb-unit
Choose a base branch
from
+1 −2
Open

fix(cu/hb): fix slot increment string concat and remove dryRun body guard #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions servers/cu/src/effects/hb/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ export const loadMessagesWith = ({ hashChain, fetch, logger: _logger, pageSize }
* Similar logic can be found below when checking for the expected nonce
*/

if (!isColdStart) from = from + 1
if (!isColdStart) from = parseInt(`${from}`) + 1
async function fetchPage ({ from }) {
const params = toParams({ processId, from, to, pageSize })

Expand All @@ -454,7 +454,6 @@ export const loadMessagesWith = ({ hashChain, fetch, logger: _logger, pageSize }
body.edges.length === (+to - +from + 1) &&
+body.edges[0]?.node?.assignment?.Tags?.find(t => t.name === 'Nonce' || t.name === 'Slot')?.value === +from
if (bodyIsValid) return body
if (!dryRun) throw new Error('Body is not valid: would attempt to fetch from scheduler in loadMessages')
return fetchPageDataloader.load({ suUrl, processId, from, to, pageSize })
},
{ maxRetries: 1, delay: 500, log: logger, name: `loadMessages(${JSON.stringify({ suUrl, processId, params: params.toString() })})` }
Expand Down