Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cu): map signature, data, anchor fields in loadprocess #971 #976

Merged
merged 2 commits into from
Aug 28, 2024
Merged

chore(cu): map signature, data, anchor fields in loadprocess #971 #976

merged 2 commits into from
Aug 28, 2024

Conversation

jfrain99
Copy link
Contributor

Closes #971.

Maps signature, data, and anchor fields to return from SU loadProcess.

TillaTheHun0
TillaTheHun0 reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to use this as an opportunity to add a test for loadProcessWith in for the ao-su client; it currently is not tested :(

TillaTheHun0
TillaTheHun0 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jfrain99 jfrain99 merged commit 034604c into main Aug 28, 2024
3 checks passed
@jfrain99 jfrain99 deleted the jfrain99/map-loadprocess-fields branch August 28, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TillaTheHun0 TillaTheHun0 TillaTheHun0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(cu): map signature, data, and anchor fields in loadProcess
2 participants
@jfrain99 @TillaTheHun0