Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-cli): auto-set memory-limit flag based on module requirements #983

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

PeterFarber
Copy link
Contributor

Closes #979

Auto sets the Memory-Limit tag when using ao publish

Copy link
Contributor

@twilson63 twilson63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would recommend memory limit to default to 512-mb or 1-gb

@PeterFarber PeterFarber force-pushed the peterfarber/devcli-memory-limit-flag branch from 02237ea to a1ea58d Compare August 28, 2024 19:46
Copy link
Contributor

@twilson63 twilson63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterFarber PeterFarber merged commit 411661f into main Sep 26, 2024
3 checks passed
@PeterFarber PeterFarber deleted the peterfarber/devcli-memory-limit-flag branch September 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(dev-cli): Auto-set Memory-Limit flag based on module requirements during ao publish
2 participants