Support setting dataSourceConfig through secrets or extraEnv#51
Merged
RazcoDev merged 2 commits intopermitio:masterfrom Aug 10, 2023
Merged
Conversation
added 2 commits
August 10, 2023 11:33
Adding a fourth option to set the config to null, which will leave the variable out completely, assuming it will be passed through env or secret.
RazcoDev
approved these changes
Aug 10, 2023
philipclaesson
pushed a commit
to northvolt/opal-helm-chart
that referenced
this pull request
Aug 10, 2023
In my latest pr permitio#51, I introduced functionality that would avoid setting the OPAL_DATA_UPDATER_ENABLED variable on the client if the variable was set on the server. This is obviously a bit confusing. We should instead override the client env var on the client itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two changes which are necessary in order to support passing dataSourceConfig as an env variable (through extraEnv or secrets) rather than via values.yaml.
Before this change, running template with an empty datasources object
and also passing an extraEnv containing
OPAL_DATA_UPDATER_ENABLEDwould yield two conflicting definitions of the
OPAL_DATA_UPDATER_ENABLED:After this change, the value passed in extraEnv takes precedence
Furthermore, with config: null we do not set
OPAL_DATA_CONFIG_SOURCES, and assume that it will be passed through extraEnv or secret.