Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2E tests framework using PyTest #681

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

varshith257
Copy link

@varshith257 varshith257 commented Oct 11, 2024

Fixes Issue

Closes #677
/claim #677

Changes proposed

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 1c6b3ea
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/672340baa950690008fbb4c8

@varshith257
Copy link
Author

@gemanor / @danyi1212 Have a check on the initial configuration done. Once it is on the way expected I proceed for next steps as outlined in the issue

@varshith257
Copy link
Author

@gemanor Any review on this?

@gemanor
Copy link
Collaborator

gemanor commented Oct 13, 2024

Hey, @varshith257, this is a very basic PR, and we are looking for something much more extensive from that:

  1. Explain your design and why you choose to run the docker as a sub-process
  2. Why is there a new docker requirement?
  3. Write a guidelines for new tests
  4. Run the assertions and tests we asked
  5. Create more stable tests of the log checks etc.

You can continue the discussion and show the plan here before continue with the code if you prefer

@varshith257
Copy link
Author

@gemanor Yeah I have just laid out foundation and pushed here to know whether it aligns with the same.

Yeah! I will document all the above :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create E2E tests framework using PyTest
2 participants