Added retry for docker tests #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
gideonsmila
reviewed
Nov 18, 2024
danyi1212
force-pushed
the
dan/per-11148-added-try-to-opal-e2e-tests
branch
2 times, most recently
from
7b4c02c
to
3b52baf
Compare
gideonsmila
reviewed
Nov 18, 2024
app-tests/run_retry.sh
Outdated
| RETRY_COUNT=0 | ||
|
|
||
| while [ $RETRY_COUNT -lt $MAX_RETRIES ]; do | ||
| echo "Running test (attempt $((RETRY_COUNT+1)) of $MAX_RETRIES)..." |
There was a problem hiding this comment.
don't knwo if printf support here but that little more "clean"
printf "Running test (attempt %d of %d)...\n" $((++RETRY_COUNT)) $MAX_RETRIES
danyi1212
force-pushed
the
dan/per-11148-added-try-to-opal-e2e-tests
branch
from
3b52baf
to
eaeba15
Compare
danyi1212
force-pushed
the
dan/per-11148-added-try-to-opal-e2e-tests
branch
from
eaeba15
to
b028772
Compare
gideonsmila
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers