add control over the number of SMs to be used by the kernel#16
Open
Amir-19 wants to merge 1 commit intoperplexityai:masterfrom
Open
add control over the number of SMs to be used by the kernel#16Amir-19 wants to merge 1 commit intoperplexityai:masterfrom
Amir-19 wants to merge 1 commit intoperplexityai:masterfrom
Conversation
Amir-19
force-pushed
the
parametrize_kernel
branch
4 times, most recently
from
a6cd433 to
5c9dead
Compare
Amir-19
force-pushed
the
parametrize_kernel
branch
from
5c9dead to
7d51605
Compare
Amir-19
force-pushed
the
parametrize_kernel
branch
from
7d51605 to
0487e8a
Compare
nandor
requested changes
May 22, 2025
Collaborator
nandor
left a comment
nandor
left a comment
There was a problem hiding this comment.
I think this is a good addition, however the parameter would be better placed on the calls to dispatch/combine themselves. This way, a single instantiation of all-to-all can be re-used in multiple contexts (prefill/decode/cuda-graph/no-cuda-graph).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added optional parameter
max_sm_countto the kernel to specify the number of SMs to use in the kernel.