Modify the blink(1) recipe to allow direct lookup of serial number#10
Open
coledot wants to merge 3 commits intoperryn:masterfrom
Open
Modify the blink(1) recipe to allow direct lookup of serial number#10coledot wants to merge 3 commits intoperryn:masterfrom
coledot wants to merge 3 commits intoperryn:masterfrom
Conversation
Owner
|
Hi @coledot Thanks for the pull request! A few questions/concerns
cheers |
Author
|
Hi @perryn, I modified the Light code to track both the handle and device for a given blink(1), instead of just the handle. Also, in the blink_1.rb recipe, I added a I've fixed the specs as well. The whitespace modifications are to remove excess spaces from the end of lines--just a minor cleanup/annoyance I wanted to deal with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handy for assigning a specific blink(1) to a specific task.