Support RGB, hex values, and add known colours to DC Webmail Notifier#6
Open
Aupajo wants to merge 1 commit intoperryn:masterfrom
Open
Support RGB, hex values, and add known colours to DC Webmail Notifier#6Aupajo wants to merge 1 commit intoperryn:masterfrom
Aupajo wants to merge 1 commit intoperryn:masterfrom
Conversation
Owner
|
Hi there Thanks for sending a pull request! However, I'm not sure why you want to add methods that allow client code to set colour directly? Generally in blinky CI plugins call methods like (failure!, success!, warning!, etc) and it is up to the light plugin implementation to map that to a colour (or whatever). Why did you find these colour methods useful? |
Author
|
Oh, I'm not using this library for CI. I'm using it as a general-purpose indicator. I've written a game using it, which flashes between colours, and a colour picker that you can choose to set the colour of the light to any hex value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
sendtosend_data, to avoid overriding Ruby's coresendmethod.colour_rgb!method (usage:colour_rgb!(255, 0, 255))colour_hex!method (usage:colour_hex!("00ff00"))black,white,green,red,blue,orange,teal,yellow,pink