Fix db struct definition #104
Merged
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I know there is this way to check statically an interface is properly implemented, but the other way works as well most of the time. |
The `db` struct doesn't need to embed the `Database` interface. Instead we can verify that it satisfies the interface which would detect when the definition of the interface changes (new method for instance). The change has also been applied to the other structs following the same pattern. Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
remove-database-interface
branch
from
3910483 to
1efb5cd
Compare
Nexucis
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dbstruct doesn't need to embed theDatabaseinterface. Instead we can verify that it satisfies the interface which would detect when the definition of the interface changes (new method for instance).