Skip to content

Commit

Permalink
Change: erc20_depositor: format with lint
Browse files Browse the repository at this point in the history
  • Loading branch information
sophia1ch committed Nov 14, 2023
1 parent 67d3469 commit 0bb09be
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions channel/erc20_depositor.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const erc20DepositorNumTx = 2
var mu sync.Mutex
var locks = make(map[string]*sync.Mutex)

// Type to create DepositResult instance
// Type to create DepositResult instance.

Check warning on line 52 in channel/erc20_depositor.go

View workflow job for this annotation

GitHub Actions / Lint

exported: comment on exported type DepositResult should be of the form "DepositResult ..." (with optional leading article) (revive)
type DepositResult struct {
Transactions types.Transactions
Error error
Expand Down Expand Up @@ -88,6 +88,7 @@ func NewERC20Depositor(token common.Address) *ERC20Depositor {
return &ERC20Depositor{Token: token}
}

// nolint:funlen

Check warning on line 91 in channel/erc20_depositor.go

View workflow job for this annotation

GitHub Actions / Lint

exported: comment on exported method ERC20Depositor.Deposit should be of the form "Deposit ..." (revive)
func (d *ERC20Depositor) Deposit(ctx context.Context, req DepositReq) (types.Transactions, error) {
lockKey := lockKey(req.Account.Address, req.Asset.EthAddress())
lock := handleLock(lockKey)
Expand Down Expand Up @@ -170,28 +171,28 @@ func (d *ERC20Depositor) DepositOnly(ctx context.Context, req DepositReq) (*type
lock := handleLock(lockKey)

var result *types.Transaction
var error error
var resError error

lockAndUnlock(lock, func() {
// Bind a `AssetHolderERC20` instance.
assetholder, err := assetholdererc20.NewAssetholdererc20(req.Asset.EthAddress(), req.CB)
if err != nil {
error = errors.Wrapf(err, "binding AssetHolderERC20 contract at: %x", req.Asset)
resError = errors.Wrapf(err, "binding AssetHolderERC20 contract at: %x", req.Asset)
result = nil
}
// Deposit.
opts, err := req.CB.NewTransactor(ctx, ERC20DepositorTXGasLimit, req.Account)
if err != nil {
error = errors.WithMessagef(err, "creating transactor for asset: %x", req.Asset)
resError = errors.WithMessagef(err, "creating transactor for asset: %x", req.Asset)
result = nil
}

tx2, err := assetholder.Deposit(opts, req.FundingID, req.Balance)
err = cherrors.CheckIsChainNotReachableError(err)
result = tx2
error = errors.WithMessage(err, "AssetHolderERC20 depositing")
resError = errors.WithMessage(err, "AssetHolderERC20 depositing")
})
return result, error
return result, resError
}

// NumTX returns 2 since it does IncreaseAllowance and Deposit.
Expand Down

0 comments on commit 0bb09be

Please sign in to comment.