Skip to content

bump toolchain to 1.85#1160

Merged
tomtau merged 1 commit intopest-parser:masterfrom
tomtau:bump-toolchain
Mar 17, 2026
Merged

bump toolchain to 1.85#1160
tomtau merged 1 commit intopest-parser:masterfrom
tomtau:bump-toolchain

Conversation

@tomtau
Copy link
Contributor

@tomtau tomtau commented Mar 17, 2026

Summary by CodeRabbit

  • Chores
    • Updated Rust toolchain versions in CI configuration to use the latest stable and nightly releases.

@tomtau tomtau requested a review from a team as a code owner March 17, 2026 14:35
@tomtau tomtau enabled auto-merge (squash) March 17, 2026 14:35
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

📝 Walkthrough

Walkthrough

Updated Rust toolchain versions across GitHub Actions configuration files. The action setup default toolchain incremented from 1.80.0 to 1.85.0, and CI workflow toolchain references updated from 1.83.0 to 1.85.0 alongside nightly toolchain date updates.

Changes

Cohort / File(s) Summary
Rust Toolchain Version Bumps
.github/actions/setup/action.yml, .github/workflows/ci.yml
Updated default and workflow Rust toolchain versions: action setup from 1.80.0 to 1.85.0; CI workflow from 1.83.0 to 1.85.0; nightly toolchains from nightly-2025-08-20 to nightly-2026-01-20 in no_std and semver-related steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • bump the CI toolchain to 1.82 #1101: Bumps Rust toolchain version strings in GitHub Actions workflow and setup configuration files.
  • bump toolchain #1090: Updates the same GitHub Actions files (.github/workflows/ci.yml and .github/actions/setup/action.yml) to increment Rust toolchain defaults and versions.
  • bump toolchain for cargo-msrv #1046: Modifies repository GitHub CI/toolchain configuration by updating toolchain versions in the same configuration files.

Suggested reviewers

  • NoahTheDuke

Poem

🐰 A whisker twitch, a hop, hooray!
Rust toolchains climb version-way,
From eighty to eighty-five we leap,
With nightly dates in bundles steep,
Our action scripts now shine so bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping the Rust toolchain version to 1.85 across both the setup action and CI workflow configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)

159-163: ⚠️ Potential issue | 🟠 Major

Update hardcoded nightly version in semvercheck.sh.

The CI workflow installs nightly-2026-01-20 (line 159), but semvercheck.sh hardcodes nightly-2025-08-20 on lines 11 and 24. Update both occurrences to match the workflow's nightly version.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 159 - 163, The semvercheck.sh script
still hardcodes the old toolchain string "nightly-2025-08-20" in two places;
update both occurrences in semvercheck.sh to "nightly-2026-01-20" so the script
matches the CI workflow's toolchain value (ensure you replace the exact string
"nightly-2025-08-20" wherever it appears, e.g., the two hardcoded nightly
variables/values).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 159-163: The semvercheck.sh script still hardcodes the old
toolchain string "nightly-2025-08-20" in two places; update both occurrences in
semvercheck.sh to "nightly-2026-01-20" so the script matches the CI workflow's
toolchain value (ensure you replace the exact string "nightly-2025-08-20"
wherever it appears, e.g., the two hardcoded nightly variables/values).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d09161d-ccfb-477c-a19a-0bfbc6dbea68

📥 Commits

Reviewing files that changed from the base of the PR and between 79dd30d and bb24676.

📒 Files selected for processing (2)
  • .github/actions/setup/action.yml
  • .github/workflows/ci.yml

@tomtau tomtau merged commit 587f8e5 into pest-parser:master Mar 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant