Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing PR checks #17

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Fixing PR checks #17

wants to merge 2 commits into from

Conversation

naxvog
Copy link
Contributor

@naxvog naxvog commented Oct 1, 2024 •
edited
Loading

Modified the composer.json file to:

  1. impersonate as another module to circumvent the cyclic dependency issue;
  2. replace any pestphp/pest-plugin-arch packages by the current package.

@naxvog naxvog changed the title Testing gh composer workflow Draft: Testing gh composer workflow Oct 1, 2024
@naxvog naxvog changed the title Draft: Testing gh composer workflow Testing gh composer workflow Oct 1, 2024
@naxvog naxvog marked this pull request as draft October 1, 2024 19:41
@naxvog naxvog force-pushed the gh-workflows branch 12 times, most recently from 1928028 to d0e50aa Compare October 1, 2024 20:27
@naxvog naxvog changed the title Testing gh composer workflow Fixing PR checks Oct 1, 2024
@naxvog naxvog marked this pull request as ready for review October 1, 2024 20:31
@naxvog naxvog mentioned this pull request Oct 1, 2024
Open
@naxvog
Copy link
Contributor Author

naxvog commented Oct 3, 2024

@nunomaduro I can create a PR in every pest plugin fixing its tests if you are interested. Just trying to avoid unnecessary PR spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@naxvog