Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to respond with an immediate Ok when receiving an EchoRequest #42

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

kimhanbeom
Copy link
Contributor

Closes: #41

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #42 (e594f37) into main (7b86515) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   82.12%   81.85%   -0.28%     
==========================================
  Files           5        5              
  Lines         828      821       -7     
==========================================
- Hits          680      672       -8     
- Misses        148      149       +1     
Files Changed Coverage Δ
src/request.rs 71.93% <100.00%> (-0.22%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@syncpark syncpark self-requested a review July 27, 2023 05:50
@syncpark syncpark merged commit 92c1897 into petabi:main Jul 27, 2023
7 of 8 checks passed
@msk msk mentioned this pull request Jul 28, 2023
@kimhanbeom kimhanbeom deleted the david-fix-response branch August 2, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to respond immediately instead of calling the handler for EchoRequest
2 participants