Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handshake implementation #68

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Remove handshake implementation #68

merged 1 commit into from
Apr 3, 2024

Conversation

msk
Copy link
Member

@msk msk commented Apr 1, 2024

They are protocol-specific and should be implemented by a higher-level crate.

This is a part of #60.

They are protocol-specific and should be implemented by a higher-level
crate.
@msk msk added the refactor Code refactoring label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.41%. Comparing base (9351072) to head (97c20d0).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #68       +/-   ##
===========================================
- Coverage   66.88%   55.41%   -11.48%     
===========================================
  Files           5        5               
  Lines         598      406      -192     
===========================================
- Hits          400      225      -175     
+ Misses        198      181       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msk msk self-assigned this Apr 3, 2024
@msk msk merged commit 97c20d0 into main Apr 3, 2024
16 checks passed
@msk msk deleted the handshake branch April 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant