Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parse_args #72

Closed
wants to merge 1 commit into from
Closed

Add parse_args #72

wants to merge 1 commit into from

Conversation

msk
Copy link
Member

@msk msk commented Apr 4, 2024

This combines the argument parsing logic from the request handler into a new function, in order to reduce the redundancy of the argument parsing logic.

It is declared as pub so that it can be used by crates implementing custom request handlers.

@msk msk added the refactor Code refactoring label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 58.22%. Comparing base (adb96ff) to head (f7eebd1).

Files Patch % Lines
src/request.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   56.17%   58.22%   +2.05%     
==========================================
  Files           5        5              
  Lines         397      383      -14     
==========================================
  Hits          223      223              
+ Misses        174      160      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This combines the argument parsing logic from the request handler
into a new function, in order to reduce the redundancy of the
argument parsing logic.

`parse_args` and `send_response` are declared as `pub` so that it can
be used by crates implementing custom request handlers.
@msk
Copy link
Member Author

msk commented Apr 4, 2024

Superseded by #73.

@msk msk closed this Apr 4, 2024
@msk msk deleted the parse-args branch April 4, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant