Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom RecvError with std::io::Error #75

Merged
merged 1 commit into from
May 10, 2024
Merged

Replace custom RecvError with std::io::Error #75

merged 1 commit into from
May 10, 2024

Conversation

msk
Copy link
Member

@msk msk commented May 9, 2024

This commit simplifies error handling by replacing the custom RecvError with the standard std::io::Error. The changes affect functions involved in receiving and parsing data, specifically in the frame and message modules.

This commit simplifies error handling by replacing the custom
`RecvError` with the standard `std::io::Error`. The changes affect
functions involved in receiving and parsing data, specifically in the
`frame` and `message` modules.
@msk msk added the refactor Code refactoring label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 17.14286% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 72.88%. Comparing base (62c56c8) to head (29ad689).

Files Patch % Lines
src/frame.rs 18.96% 47 Missing ⚠️
src/request.rs 0.00% 7 Missing ⚠️
src/message.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #75       +/-   ##
===========================================
- Coverage   88.79%   72.88%   -15.92%     
===========================================
  Files           4        4               
  Lines         241      295       +54     
===========================================
+ Hits          214      215        +1     
- Misses         27       80       +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msk msk merged commit 29ad689 into main May 10, 2024
12 of 16 checks passed
@msk msk deleted the recv-error branch May 10, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant