Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #77

Closed
wants to merge 0 commits into from

Conversation

kimhanbeom
Copy link
Contributor

  • Update quinn to 0.11.
  • Update rustls to 0.23.
  • Update rcgen to 0.13.
  • Modify the associated code based on the crate's versioning of dependencies.

Close: #76

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.11%. Comparing base (62c56c8) to head (2868c1c).

Files Patch % Lines
src/test.rs 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   88.79%   89.11%   +0.31%     
==========================================
  Files           4        4              
  Lines         241      248       +7     
==========================================
+ Hits          214      221       +7     
  Misses         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cargo.toml Outdated
@@ -13,14 +13,17 @@ license = "Apache-2.0"
bincode = "1"
futures = "0.3"
num_enum = "0.7"
quinn = "0.10"
quinn = { version = "0.11", features = ["ring"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the ring feature needed for test only? If so, keep the quinn dependency without ring (quinn = "0.11"), and add the ring feature in dev-dependencies only. In that way, other crates depending on this crate won't have to build ring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve created a new PR because the current issue was accidentally closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rustls / quinn version
2 participants