Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io::Error instead of SendError #80

Merged
merged 1 commit into from
May 20, 2024
Merged

Use io::Error instead of SendError #80

merged 1 commit into from
May 20, 2024

Conversation

msk
Copy link
Member

@msk msk commented May 17, 2024

This PR refactors the error handling mechanism for the send functions, replacing the custom SendError type with the standard io::Error. This change simplifies the error management and leverages the comprehensive error handling provided by the io::Error type.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.26%. Comparing base (e585df2) to head (7d27ea8).

Files Patch % Lines
src/request.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files           4        4           
  Lines         303      303           
=======================================
  Hits          222      222           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msk msk merged commit 7d27ea8 into main May 20, 2024
14 of 16 checks passed
@msk msk deleted the send-error branch May 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant