Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function comments based on best practices from Effective Go #22

Merged
merged 1 commit into from
May 14, 2019
Merged

Fix function comments based on best practices from Effective Go #22

merged 1 commit into from
May 14, 2019

Conversation

CodeLingoBot
Copy link
Contributor

Signed-off-by: CodeLingo Bot [email protected]

@mullikine
Copy link

Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name being declared.
From effective go.

I generated this with CodeLingo and I'm keen to get some feedback, but this is automated so feel free to close it and just say "opt out" to opt out of future CodeLingo outreach PRs.

@mullikine
Copy link

I have looked over each of the changes made by the bot, and it appears to have fixed some very trivial issues in your function comments. One side effect of the current algorithm used by the tenet that generated this PR is that it removes parentheses from the inital word of a function comment if that word refers to the function name, in order to make the sentence flow a little better. If this doesn't seem right to you, please let me know so I can remove that logic for future users.

If the issue is too trivial, feel free to close and ignore this PR. Although your feedback is incredibly valuable to us.

Note: I've only updated functions that I know CodeLingo can rewrite nicely, but you can install it from the GitHub marketplace to review your PRs automatically and find all issues.

@petar petar merged commit 33fb24c into petar:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants