Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos and a bit of rewording #536

Merged
merged 1 commit into from
Feb 18, 2025
Merged

typos and a bit of rewording #536

merged 1 commit into from
Feb 18, 2025

Conversation

jpmens
Copy link
Contributor

@jpmens jpmens commented Feb 18, 2025

Upon scrolling through the (excellent!) documentation of this plugin (I’m looking forward to testing it soon) I stumbled over a few typos.

I also took the liberty of s/state/version for the SOA serial number, it it’s not really state which is recorded on the primary, but more of a version number which is compared between secondary and primary.

When SOA REFRESH elapses, a secondary will again query SOA for SERIAL and then decide whether or not to XFR. (When EXPIRE is reached after not being able to contact a primary, the secondary will stop responding to queries for the zone; REFUSED will be returned as rcode)

Upon scrolling through the (excellent!) documentation of this plugin (I’m looking forward to testing it soon) I stumbled over a few typos.

I also took the liberty of `s/state/version` for the SOA serial number, it it’s not really _state_ which is recorded on the primary, but more of a _version_ number which is compared between secondary and primary.

When SOA REFRESH elapses, a secondary will again query SOA for SERIAL and then decide whether or not to XFR. (When EXPIRE is reached after not being able to contact a primary, the secondary will stop responding to queries for the zone; REFUSED will be returned as rcode)
@peteeckel
Copy link
Owner

@jpmens Thanks a lot, this is very welcome! As usual, documentation comes last after a day's work ... good to know that someone actually looks at the documentation!

@peteeckel peteeckel merged commit 4519e18 into peteeckel:main Feb 18, 2025
4 checks passed
@jpmens
Copy link
Contributor Author

jpmens commented Feb 18, 2025

I've been meaning to look at Netbox for a while and used your very good FOSDEM talk (which I watched online) as a trigger to baby steps in using Netbox.

I hope to look more closely at your DNS plugin very soon. 😄

@jpmens jpmens deleted the patch-2 branch February 18, 2025 18:28
@peteeckel
Copy link
Owner

peteeckel commented Feb 18, 2025

I'm looking forward to your comments. If you run into any problems, please don't hesitate to ask or open issues - I'm trying to improve the plugin constantly, but at some point you run out of ideas eventually..

I've started preparing a more hands-on talk for a different audience (less developers, more DDI practictioners) I'm going to hold this summer as a result of the FOSDEM talk ... that one seems to keep me busy for a while (not that I haven't been busy before :-)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants