Replace inotify with notify crate for device hotplug detection#112
Closed
krystophny wants to merge 1 commit intopeteonrails:mainfrom
Closed
Replace inotify with notify crate for device hotplug detection#112krystophny wants to merge 1 commit intopeteonrails:mainfrom
krystophny wants to merge 1 commit intopeteonrails:mainfrom
Conversation
This switches the device hotplug detection in the evdev listener from using inotify directly to using the notify crate, which abstracts filesystem watching across platforms. Benefits: - Cleaner dependency (notify is already used for status --follow) - The notify crate is better maintained and more widely used - Prepares codebase for future cross-platform support The notify crate uses inotify internally on Linux, so behavior is unchanged on the primary platform.
krystophny
force-pushed
the
upstream-pr-notify
branch
from
762f39b to
def61dd
Compare
Owner
|
Superseded by #129 which incorporates cross-platform device hotplug support. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
voxtype status --followstill workscargo teston Linux