Draft
Conversation
Implements Voice Activity Detection with two backends: - WhisperVad: Uses whisper-rs built-in VAD (GGML Silero model) - SileroVad: Uses voice_activity_detector crate (ONNX Silero model) WhisperVad works, but SileroVad is blocked on ort API compatibility. The voice_activity_detector 0.2.0 crate uses an older ort API that conflicts with parakeet-rs's ort version. This branch preserves the work for when: - voice_activity_detector updates to support newer ort - Or we find an alternative Silero ONNX implementation See feature/vad-silence-filter for the working energy-based VAD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Voice Activity Detection with engine-specific backends:
voice_activity_detectorcrate for Parakeet builds - blocked on ort compatibilityStatus: Blocked
The
voice_activity_detector0.2.0 crate uses an olderortAPI that conflicts withparakeet-rs's ort version. Build fails with API mismatch errors when theparakeetfeature is enabled.Unblocking options
voice_activity_detectorto update for newer ort versionsvoice_activity_detectorRelated
feature/vad-silence-filterfor the working energy-based VAD (no external dependencies)