Switching parsing to legacy

peter-murray · Oct 11, 2024 · 945da31 · 945da31
1 parent 7566a33
commit 945da31
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 13 deletions.
diff --git a/dist/main/index.js b/dist/main/index.js
diff --git a/dist/main/index.js.map b/dist/main/index.js.map
diff --git a/dist/post/index.js b/dist/post/index.js
diff --git a/dist/post/index.js.map b/dist/post/index.js.map
diff --git a/lib/github-application.js b/lib/github-application.js
@@ -3,7 +3,7 @@ const jwt = require('jsonwebtoken')
   , core = require('@actions/core')
   , PrivateKey = require('./private-key')
   , HttpsProxyAgent = require('https-proxy-agent').HttpsProxyAgent
-  , URL = require('node:url')
+  , url = require('node:url')
   ;
 
 module.exports.create = (privateKey, applicationId, baseApiUrl, timeout, proxy) => {
@@ -239,14 +239,15 @@ function proxyExcluded(noProxy, baseUrl) {
     core.debug(`noProxyHosts = ${JSON.stringify(noProxyHosts)}`);
 
     core.debug(`parsing baseURL: '${baseUrl}'`);
-    try {
-      const parsedBaseUrl = new URL(baseUrl);
-      core.debug(`parsed = ${parsedBaseUrl}`);
-      core.debug(`base url host = '${parsedBaseUrl.host}'`);
-    } catch (err) {
-      core.error(`Failure in parsing the URL object`);
-      throw err;
-    }
+    // try {
+      // const parsedBaseUrl = new URL(baseUrl);
+    //   core.debug(`parsed = ${parsedBaseUrl}`);
+    //   core.debug(`base url host = '${parsedBaseUrl.host}'`);
+    // } catch (err) {
+    //   core.error(`Failure in parsing the URL object`);
+    //   throw err;
+    // }
+    const parsedBaseUrl = url.parse(baseUrl);
 
     return noProxyHosts.indexOf(parsedBaseUrl.host) > -1;
   }