Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats rework (1/3): Interfaces and implementations for tiers #24

Open
wants to merge 34 commits into
base: ehcache-disk-integ-base
Choose a base branch
from
Open

Stats rework (1/3): Interfaces and implementations for tiers #24

wants to merge 34 commits into from

Commits on Feb 8, 2024

  1. CacheStats interface and SingleDimensionCacheStats impl 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    641abf1 View commit details
    Browse the repository at this point in the history

  2. First attempt to integrate new stats with EhcacheDiskCache 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    937ca51 View commit details
    Browse the repository at this point in the history

  3. Adds Serializer interface and impls for Key and BytesReference 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    21b1078 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Adds ICacheKey serializer impl 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a460acd View commit details
    Browse the repository at this point in the history

  2. Added more icachekey serializer tests 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    31ee9ae View commit details
    Browse the repository at this point in the history

  3. Attempts to fix ehcache hits 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9069077 View commit details
    Browse the repository at this point in the history

  4. Fixed unexpected misses by implementing hashCode for ICacheKey and Ca… 

    …cheStatsDimension

Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    18ddb23 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Adds memory tracking to disk tier 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    8618458 View commit details
    Browse the repository at this point in the history

  2. Updated other tests 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    46b3e49 View commit details
    Browse the repository at this point in the history

  3. Added partial memory tests 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    51ea583 View commit details
    Browse the repository at this point in the history

  4. Changed cache stats API to get values by dimension list 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    17cf26a View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Cleanup 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    be5eece View commit details
    Browse the repository at this point in the history

  2. Redid memory tracking to use already implemented weigher fn 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a6b0899 View commit details
    Browse the repository at this point in the history

  3. Split CacheStats into CacheStats and CacheStatsBase, which can't upda… 

    …te stats

Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9b1e66c View commit details
    Browse the repository at this point in the history

  4. Readded BytesReferenceSerializer impl as ICacheKeySerializerTests dep… 

    …ended on it

Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    01e04a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Changed SingleDimensionCacheStats to use ConcurrentMap 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3777e3f View commit details
    Browse the repository at this point in the history

  2. Made SingleDimensionCacheStats also take in tier dimensions 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6059680 View commit details
    Browse the repository at this point in the history

  3. Added overall CacheStatsResponse object packaging all 5 metrics 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7f5a455 View commit details
    Browse the repository at this point in the history

  4. Removed skeleton TSC stats implementation 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    36c600d View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge remote-tracking branch 'sgup432/ehcache_disk_integ' into rework… 

    …ed-stats-tiers
    Peter Alfonsi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    27fdfe1 View commit details
    Browse the repository at this point in the history

  2. Modified factories to take new arguments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c8dc1b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. added utilitly fns to CacheStatsResponse 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4abd602 View commit details
    Browse the repository at this point in the history

  2. Making TieredCachePlugin constructor public 

    Signed-off-by: Sagar Upadhyaya <[email protected]>
    @sgup432
    sgup432 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2586fa1 View commit details
    Browse the repository at this point in the history

  3. Fixing CacheService unit test 

    Signed-off-by: Sagar Upadhyaya <[email protected]>
    @sgup432
    sgup432 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6a2b374 View commit details
    Browse the repository at this point in the history

  4. Added multi dimension cache stats impl 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3e7ea26 View commit details
    Browse the repository at this point in the history

  5. Removed SingleDimensionCacheStats 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b4c83e7 View commit details
    Browse the repository at this point in the history

  6. Adds IRC key serializer 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d579c51 View commit details
    Browse the repository at this point in the history

  7. Addressed Sagar's other comment 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c34c218 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge remote-tracking branch 'sgup432/ehcache_disk_integ' into rework… 

    …ed-stats-tiers
    Peter Alfonsi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2f4bd4f View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Fixed on heap stats integration, added tests 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a61f033 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Optimized multi dimension stats 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2483981 View commit details
    Browse the repository at this point in the history

  2. Added reset() to CacheStats 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2aeaa53 View commit details
    Browse the repository at this point in the history

  3. Fixed reset impl for multi dim stats 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    60df761 View commit details
    Browse the repository at this point in the history

  4. spotlessApply 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ea33af8 View commit details
    Browse the repository at this point in the history