Don't reconnect to send pipelined request no-op #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sending the pipelined get commands fails with a network error, the socket will be closed when we try to send the no-op command. `alive?` reconnects if possible, but we only need to send the no-op if the get commands were successfully sent. Before c01d410, reconnecting to send a no-op was harmless, but now that pipelined requests are tracked in their entirety, an error is raised since there is no request in progress.
petergoldstein
force-pushed
the
pipeline_connected
branch
from
51bf6d5
to
b1a1fac
Compare
|
Thanks @eugeneius . Rebased to address some test/rubocop issues. If this runs green I'll merge. |
|
Good catch here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #966.
If sending the pipelined get commands fails with a network error, the socket will be closed when we try to send the no-op command.
alive?reconnects if possible, but we only need to send the no-op if the get commands were successfully sent.Before #963, reconnecting to send a no-op was harmless, but now that pipelined requests are tracked in their entirety, an error is raised since there is no request in progress.