Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on base64 #986

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Earlopain
Copy link
Contributor

#982 added base64 as a dependency in order to avoid a warning with Ruby 3.3

The base64 gem is mostly a wrapper around pack/unpack and as such is easy to replace. Other gems have opted for the same approach:

@petergoldstein
Copy link
Owner

I like this approach.

@petergoldstein
Copy link
Owner

Thanks @Earlopain

@petergoldstein petergoldstein merged commit c409a07 into petergoldstein:main Feb 1, 2024
21 checks passed
@Earlopain Earlopain deleted the drop-base64-dep branch February 1, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants