Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/chrome-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ import { tidy } from "./anchor-text.js";
import { pageUrl, replacePage } from "./chrome-session.js";
import { framePolicy } from "./frame-policy.js";

/**
* True when an "Enter" keydown is really an IME confirming its composition
* (e.g. finalizing kanji conversion), not the user asking to submit.
*/
function isImeCommitEnter(event) {
return Boolean(event.isComposing || event.keyCode === 229);
}

const $ = (id) => document.getElementById(id);
const frame = $("frame");

Expand Down Expand Up @@ -392,6 +400,7 @@ function editComment(card, body, comment) {
input.addEventListener("keydown", (event) => {
event.stopPropagation();
if (event.key === "Enter" && !event.shiftKey) {
if (isImeCommitEnter(event)) return;
event.preventDefault();
commit();
}
Expand Down Expand Up @@ -640,6 +649,7 @@ $("compose").addEventListener("mousedown", (event) => {

$("composeText").addEventListener("keydown", (event) => {
if (event.key === "Enter" && !event.shiftKey) {
if (isImeCommitEnter(event)) return;
event.preventDefault();
commitCompose();
}
Expand Down Expand Up @@ -764,6 +774,7 @@ function applyTheme(dark) {
document.addEventListener("keydown", (event) => {
const meta = event.metaKey || event.ctrlKey;
if (meta && event.key === "Enter") {
if (isImeCommitEnter(event)) return;
event.preventDefault();
if (!$("send").disabled) $("send").click();
return;
Expand Down
9 changes: 9 additions & 0 deletions src/sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ import { hashClickAction, navigationHref } from "./click-target.js";
import { linkStyleFixup, listCommandFor, listStyleFixup, normalizeHref } from "./editing.js";
import { keepBodyEditable, serializeDocument, UI_ATTR, MARK_ATTR } from "./serialize.js";

/**
* True when an "Enter" keydown is really an IME confirming its composition
* (e.g. finalizing kanji conversion), not the user asking to submit.
*/
function isImeCommitEnter(event) {
return Boolean(event.isComposing || event.keyCode === 229);
}

const SAVE_DEBOUNCE_MS = 700;
const EDIT_FLUSH_MS = 500;
const MEDIA = /^(img|svg|canvas|video|picture|iframe|hr|figure)$/i;
Expand Down Expand Up @@ -1012,6 +1020,7 @@ function boot() {
els.linkInput.addEventListener("keydown", (event) => {
event.stopPropagation();
if (event.key === "Enter") {
if (isImeCommitEnter(event)) return;
event.preventDefault();
applyLink();
} else if (event.key === "Escape") {
Expand Down