Release the waiting agent on No change or tab close - #38
Open
TrickRiggin wants to merge 1 commit into
Open
Conversation
Send is disabled when there is nothing to comment, so a review that looks fine had no way to end except waiting out the poll timeout. Closing the tab also left the agent hanging. Make No change the primary empty-state action, skip the confirm when there is nothing unsent, and treat the last tab closing as the same decision after a short grace so a refresh can reconnect. Persist the closed status so a retry poll does not hang, and teach agents to stop when they see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sendis disabled when there is nothing to comment, so a review that already looks fine has no way to end except waiting out the poll timeout. Closing the tab also left the agent hanging — I kept finding leftoverhuman-review pollprocesses after I was done.There was already a faint End review control, but it was easy to miss, required a confirm even when nothing was unsent, and did not persist, so a retry poll after timeout would hang again.
Change
{"status":"closed","reason":"no_change"|"window_closed"}is persisted until the nexthuman-review <file>, so a retry poll does not hang.closedand not to leave poll running in the background.Tests
window_closed