[DNM] black -l 79 --skip-string-normalization # 21.5b1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternowee
commented
Jun 2, 2021
Comment on lines
36
to
+261
| 'showboxes', | ||
| 'style', | ||
| 'tailURL', | ||
| 'tailclip', | ||
| 'tailhref', | ||
| 'taillabel', | ||
| 'tailport', | ||
| 'tailtarget', | ||
| 'tailtooltip', | ||
| 'target', | ||
| 'tooltip', | ||
| 'weight', | ||
| 'rank', | ||
| } | ||
|
|
||
|
|
||
| NODE_ATTRIBUTES = { | ||
| 'URL', 'color', 'colorscheme', 'comment', | ||
| 'distortion', 'fillcolor', 'fixedsize', 'fontcolor', 'fontname', | ||
| 'fontsize', 'group', 'height', 'id', 'image', 'imagescale', 'label', | ||
| 'labelloc', 'layer', 'margin', 'nojustify', 'orientation', 'penwidth', | ||
| 'peripheries', 'pin', 'pos', 'rects', 'regular', 'root', 'samplepoints', | ||
| 'shape', 'shapefile', 'showboxes', 'sides', 'skew', 'sortv', 'style', | ||
| 'target', 'tooltip', 'vertices', 'width', 'z', | ||
| 'URL', | ||
| 'color', | ||
| 'colorscheme', | ||
| 'comment', | ||
| 'distortion', | ||
| 'fillcolor', | ||
| 'fixedsize', | ||
| 'fontcolor', | ||
| 'fontname', | ||
| 'fontsize', | ||
| 'group', | ||
| 'height', | ||
| 'id', | ||
| 'image', | ||
| 'imagescale', | ||
| 'label', | ||
| 'labelloc', | ||
| 'layer', | ||
| 'margin', | ||
| 'nojustify', | ||
| 'orientation', | ||
| 'penwidth', | ||
| 'peripheries', | ||
| 'pin', | ||
| 'pos', | ||
| 'rects', | ||
| 'regular', | ||
| 'root', | ||
| 'samplepoints', | ||
| 'shape', | ||
| 'shapefile', | ||
| 'showboxes', | ||
| 'sides', | ||
| 'skew', | ||
| 'sortv', | ||
| 'style', | ||
| 'target', | ||
| 'tooltip', | ||
| 'vertices', | ||
| 'width', | ||
| 'z', | ||
| # The following are attributes dot2tex | ||
| 'texlbl', 'texmode' | ||
| 'texlbl', | ||
| 'texmode', | ||
| } | ||
|
|
||
|
|
||
| CLUSTER_ATTRIBUTES = { | ||
| 'K', 'URL', 'bgcolor', 'color', 'colorscheme', | ||
| 'fillcolor', 'fontcolor', 'fontname', 'fontsize', 'label', 'labeljust', | ||
| 'labelloc', 'lheight', 'lp', 'lwidth', 'nojustify', 'pencolor', | ||
| 'penwidth', 'peripheries', 'sortv', 'style', 'target', 'tooltip' | ||
| 'K', | ||
| 'URL', | ||
| 'bgcolor', | ||
| 'color', | ||
| 'colorscheme', | ||
| 'fillcolor', | ||
| 'fontcolor', | ||
| 'fontname', | ||
| 'fontsize', | ||
| 'label', | ||
| 'labeljust', | ||
| 'labelloc', | ||
| 'lheight', | ||
| 'lp', | ||
| 'lwidth', | ||
| 'nojustify', | ||
| 'pencolor', | ||
| 'penwidth', | ||
| 'peripheries', | ||
| 'sortv', | ||
| 'style', | ||
| 'target', | ||
| 'tooltip', |
There was a problem hiding this comment.
Wow, so many new lines.
peternowee
commented
Jun 2, 2021
| return node_str | ||
|
|
||
| if node_port_idx > 0: | ||
| a = node_str[:node_port_idx] | ||
| b = node_str[node_port_idx+1:] | ||
| b = node_str[node_port_idx + 1 :] |
There was a problem hiding this comment.
Causes E203 whitespace before ':' from flake8/pycodestyle, but problem seems to be with them rather than with black. See:
- https://github.com/psf/black/blob/21.5b1/docs/the_black_code_style/current_style.md#slices
- Flake8 and PEP8 has different rule for the whitespace around colon in a slice. PyCQA/flake8#257
- E203: False positive "whitespace before ':' " on list slice. PyCQA/pycodestyle#373
- Fix false alarm in E203 rule (issue #373, black incompatibility) PyCQA/pycodestyle#914
|
This pull request has conflicts, please resolve those so that the changes can be evaluated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for discussion in pydot#265.