Skip to content

fix: auto-resolve wontfix clippy/cargo items absent after cfg(test) filtering #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fluffypony wants to merge 1 commit into from
Closed

fix: auto-resolve wontfix clippy/cargo items absent after cfg(test) filtering #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions desloppify/engine/_state/merge_issues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,24 @@ def verify_disappeared(
resolved += 1
continue

# Wontfix items from clippy/cargo that disappeared after inline-test
# filtering was introduced should be auto-resolved: the filter now
# correctly excludes test-only diagnostics, so the wontfix decision
# is obsolete.
if previous_status == "wontfix" and previous.get("detector", "") in (
"clippy_warning",
"cargo_error",
):
previous["status"] = "auto_resolved"
previous["resolved_at"] = now
previous["note"] = (
"Auto-resolved: absent from scan after inline cfg(test) "
"filtering was introduced"
)
resolved_detectors.add(previous.get("detector", "unknown"))
resolved += 1
continue

verification_note = (
"Still absent from scan after manual wontfix"
if previous_status == "wontfix"
Expand Down
Loading