Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Authentication #7

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Refactor: Authentication #7

merged 4 commits into from
Jun 28, 2021

Conversation

petrepan
Copy link
Owner

  • removed localstorage implementation on the frontend.
  • updated the server to send a response with a cookie token as an httpOnly value on the login and register routes. and also cleared cookie on the logout route.

Tahoum
Tahoum reviewed Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@Tahoum Tahoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this one 💯
Left you some comments about some minor things, please address them and once you're finished let us know in the channel.

server/db/db.js Outdated Show resolved Hide resolved
server/routes/auth/index.js Outdated Show resolved Hide resolved
@petrepan petrepan requested a review from Tahoum June 23, 2021 14:07
RayK3
RayK3 approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@RayK3 RayK3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, this one is good to go! Merge when ready 😎

server/app.js Show resolved Hide resolved
server/routes/auth/index.js Show resolved Hide resolved
server/routes/auth/index.js Show resolved Hide resolved
@petrepan petrepan merged commit 4ddec5c into main Jun 28, 2021
@petrepan petrepan linked an issue Jun 30, 2021 that may be closed by this pull request
1) Refactor: Authentication #1
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayK3 RayK3 RayK3 approved these changes

@Tahoum Tahoum Awaiting requested review from Tahoum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1) Refactor: Authentication
3 participants
@petrepan @RayK3 @Tahoum