Skip to content

Fix PrintReportNotebook #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix PrintReportNotebook #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f30f0f4
add test
linshokaku Jun 3, 2024
a0cbe73
fix test
linshokaku Jun 3, 2024
988e4c3
Merge branch 'master' into print-report-notebook-patch
linshokaku Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pytorch_pfn_extras/training/extensions/print_report_notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,7 @@ def __call__(self, manager: ExtensionsManagerProtocol) -> None:
if self._infer_entries:
# --- update entries ---
self._update_entries(log_report)
for entry in self._entries:
if entry not in df.columns:
df[entry] = None
self._widget.value = df[self._entries].to_html(index=False, na_rep="")
32 changes: 32 additions & 0 deletions tests/pytorch_pfn_extras_tests/training_tests/extensions_tests/test_print_report_notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,37 @@ def test_run_print_report_notebook(tmp_path: pathlib.Path):
pass


@pytest.mark.skipif(
not _ipython_module_available or not _pandas_available,
reason="print report notebook import failed, "
"maybe ipython is not installed",
)
def test_run_print_report_notebook_with_entry(tmp_path: pathlib.Path):
max_epochs = 5
iters_per_epoch = 5
manager = ppe.training.ExtensionsManager(
{},
{},
max_epochs,
iters_per_epoch=iters_per_epoch,
out_dir=str(tmp_path),
)

out = io.StringIO()
log_report = ppe.training.extensions.LogReport()
manager.extend(log_report)
extension = ppe.training.extensions.PrintReportNotebook(
["epoch", "iteration"], out=out
)
manager.extend(extension)

for _ in range(max_epochs):
for _ in range(iters_per_epoch):
with manager.run_iteration():
# Only test it runs without fail
# The value is not tested now...
pass


if __name__ == "__main__":
pytest.main([__file__, "-v", "-s"])
Loading