Upgrading Guzzle HTTP client + Travis PHP versions #9
Conversation
|
@pfrenssen @claudiu-cristea @brummbar @idimopoulos please review and merge... |
| sudo: false | ||
|
|
||
| env: | ||
| - TEST=PHP_CodeSniffer |
There was a problem hiding this comment.
Why is PHP CS check dropped?
| - 7.0 | ||
| - 7.1 | ||
| - 7.2 | ||
| - 7.4 |
There was a problem hiding this comment.
7.3 is still supported
There was a problem hiding this comment.
Let's keep supporting the old versions of PHP.
| }, | ||
| "require": { | ||
| "guzzlehttp/guzzle": "~6.0" | ||
| "php": "^7.4|^8.0", |
There was a problem hiding this comment.
7.3? Also we should use double pipe as OR operator as | is deprecated. See composer/composer#6755
There was a problem hiding this comment.
I don't want to impose a change of PHP version to our users. They might still be on older versions of PHP for legacy reasons.
| use Psr\Http\Message\RequestInterface; | ||
| use Psr\Http\Message\ResponseInterface; | ||
|
|
||
|
|
There was a problem hiding this comment.
Un-needed new line
| ]; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove all these lines, they’re violating the coding standards
| */ | ||
| class HttpClientTest extends TestCase | ||
| { | ||
| class HttpClientTest extends TestCase { |
There was a problem hiding this comment.
Curly bracket should be on the following line
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^5.0|^6.0|^7.0", | ||
| "phpunit/phpunit": ">5.0", |
There was a problem hiding this comment.
The minimum PHPUnit version supporting PHP 7.3 is 7. See https://phpunit.de/supported-versions.html. We have to support PHPUnit 7, 8, 9
|
@io238 please go through the reviews by @claudiu-cristea so it can be merged. |
4 participants
Adding support for Guzzle version 7. Requires PHP versions 7.4 or 8.0
This PR aims to fix previous PR #8