Merge pull request #90 from jneves/pass-params-as-array

Pass params as array
pgrange · Jun 17, 2022 · 9628fdb · 9628fdb
2 parents ade9ba2 + bbc7c38
commit 9628fdb
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/README.adoc b/README.adoc
@@ -114,6 +114,7 @@ Running tests in tests/test_core.sh
 	Running test_fake_echo_stdin_when_no_params ... SUCCESS
 	Running test_fake_exports_faked_in_subshells ... SUCCESS
 	Running test_fake_transmits_params_to_fake_code ... SUCCESS
+	Running test_fake_transmits_params_to_fake_code_as_array ... SUCCESS
 	Running test_should_pretty_format_even_when_LANG_is_unset ... SUCCESS
 Overall result: SUCCESS
 ```
@@ -185,6 +186,7 @@ ok - test_fake_can_fake_inline
 ok - test_fake_echo_stdin_when_no_params
 ok - test_fake_exports_faked_in_subshells
 ok - test_fake_transmits_params_to_fake_code
+ok - test_fake_transmits_params_to_fake_code_as_array
 ok - test_should_pretty_format_even_when_LANG_is_unset
 ```
 
@@ -664,7 +666,7 @@ test_code_gives_ps_appropriate_parameters() {
 24162 pts/7    00:00:00 ps
  8387 ?            0:00 /usr/sbin/apache2 -k start
 EOF
-    assert_equals ax "$FAKE_PARAMS"
+    assert_equals ax "${FAKE_PARAMS[@]}"
   }
   export -f _ps
   fake ps _ps
@@ -698,7 +700,7 @@ code() {
 
 test_code_gives_ps_appropriate_parameters() {
   _ps() {
-    assert_equals ax "$FAKE_PARAMS"
+    assert_equals ax "${FAKE_PARAMS[@]}"
   }
   export -f _ps
   fake ps _ps
@@ -728,7 +730,7 @@ code() {
 
 test_code_gives_ps_appropriate_parameters() {
   _ps() {
-    echo $FAKE_PARAMS > /tmp/fake_params
+    echo ${FAKE_PARAMS[@]} > /tmp/fake_params
   }
   export -f _ps
   fake ps _ps
@@ -763,7 +765,7 @@ code() {
 }
 
 test_code_gives_ps_appropriate_parameters() {
-  fake ps 'echo $FAKE_PARAMS >/tmp/fake_params'
+  fake ps 'echo ${FAKE_PARAMS[@]} >/tmp/fake_params'
 
   code || true
 
@@ -792,7 +794,7 @@ test_get_data_from_fake() {
   #Fasten you seat belt ...
   coproc cat
   exec {test_channel}>&${COPROC[1]}
-  fake ps 'echo $FAKE_PARAMS >&$test_channel'
+  fake ps 'echo ${FAKE_PARAMS[@]} >&$test_channel'
 
   code || true
 

diff --git a/bash_unit b/bash_unit
@@ -158,7 +158,7 @@ fake() {
   shift
   if [ $# -gt 0 ]
   then
-    eval "function $command() { export FAKE_PARAMS=\"\$@\" ; $@ ; }"
+    eval "function $command() { export FAKE_PARAMS=(\"\$@\") ; $@ ; }"
   else
     eval "function $command() { echo \"$($CAT)\" ; }"
   fi

diff --git a/tests/test_core.sh b/tests/test_core.sh
@@ -164,6 +164,16 @@ test_fake_transmits_params_to_fake_code() {
   ps aux
 }
 
+test_fake_transmits_params_to_fake_code_as_array() {
+  function _ps() {
+    assert_equals "1" "${#FAKE_PARAMS[@]}"
+  }
+  export -f _ps
+  fake ps _ps
+
+  ps "hello world"
+}
+
 test_fake_echo_stdin_when_no_params() {
   fake ps << EOF
   PID TTY          TIME CMD