Improved error messages

Author: ankane

include/pgvector/pqxx.hpp

@@ -133,7 +133,7 @@ template <> struct string_traits<pgvector::SparseVector> {
 
             int dimensions = std::stoi(std::string(text.substr(n + 2)));
             if (dimensions < 0) {
-                throw conversion_error("Malformed sparsevec literal");
+                throw conversion_error("Dimensions cannot be negative");
             }
 
             std::vector<int> indices;
@@ -154,7 +154,7 @@ template <> struct string_traits<pgvector::SparseVector> {
                     float value = std::stof(substr.substr(ne + 1));
 
                     if (index < 1) {
-                        throw conversion_error("Malformed sparsevec literal");
+                        throw conversion_error("Index out of bounds");
                     }
 
                     indices.push_back(index - 1);

test/pqxx_test.cpp

@@ -252,7 +252,7 @@ void test_sparsevec_from_string() {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{}/-1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "Malformed sparsevec literal");
+        assert(std::string_view(e.what()) == "Dimensions cannot be negative");
     }
 
     try {
@@ -273,14 +273,14 @@ void test_sparsevec_from_string() {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{0:1}/1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "Malformed sparsevec literal");
+        assert(std::string_view(e.what()) == "Index out of bounds");
     }
 
     try {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{-2147483648:1}/1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "Malformed sparsevec literal");
+        assert(std::string_view(e.what()) == "Index out of bounds");
     }
 
     try {