Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sampling interval and call-stack tracing depth configurable via INI... #34

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

turchanov
Copy link

...-settings instead of being hard-coded because there are use cases where 0.1s sampling interval is too coarse and INT_MAX limit on call-stack trace depth gives overly verbose traces.

@billf
Copy link
Contributor

billf commented Apr 11, 2014

@turchanov can you please sign the CLA located at https://code.facebook.com/cla

@rmccue
Copy link

rmccue commented Nov 10, 2015

Hi! We'd really love to use this; @turchanov is there any chance of you signing the CLA to get this merged? :)

@turchanov
Copy link
Author

Ok, I just have signed the CLA.

@billf
Copy link
Contributor

billf commented Nov 13, 2015

in the time between my comment above and now, ownership of xhprof transferred from facebook to phacility. the facebook CLA is no longer relevant and @epriestley has been maintaining this repo.

@janpapenbrock
Copy link

Would love to use this

@turchanov
Copy link
Author

So... Is any action still required from me or it's all up to xhprof maintainer now?

@janpapenbrock
Copy link

@turchanov I extracted your changes into a fresh PR #80, because this one contains additional files. Hope it makes it easier for the maintainer to review and possibly merge.

@Minasu Minasu mentioned this pull request Jun 20, 2016
yazshel pushed a commit to FluentDevelopment/xhprof that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants