-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made sampling interval and call-stack tracing depth configurable via INI... #34
base: master
Are you sure you want to change the base?
Conversation
call graph: changed color of arrows/edges to grey for better readability of the labels
fixes PR phacility#20 when using randomly generated run ids
Ignore build artifacts from Git
call graph: changed color of arrows/edges to grey for readability
@turchanov can you please sign the CLA located at https://code.facebook.com/cla |
Hi! We'd really love to use this; @turchanov is there any chance of you signing the CLA to get this merged? :) |
Ok, I just have signed the CLA. |
in the time between my comment above and now, ownership of xhprof transferred from facebook to phacility. the facebook CLA is no longer relevant and @epriestley has been maintaining this repo. |
Would love to use this |
So... Is any action still required from me or it's all up to xhprof maintainer now? |
@turchanov I extracted your changes into a fresh PR #80, because this one contains additional files. Hope it makes it easier for the maintainer to review and possibly merge. |
Windows support phacility#34
...-settings instead of being hard-coded because there are use cases where 0.1s sampling interval is too coarse and INT_MAX limit on call-stack trace depth gives overly verbose traces.