[WIP] Initial test of snippet #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1guelpf
reviewed
Mar 6, 2017
| @@ -4,3 +4,32 @@ | |||
| Route::get('/', function () { | |||
| return view('app'); | |||
| }); | |||
|
|
|||
| Route::get('snippet', function (\Illuminate\Http\Request $request ) { | |||
There was a problem hiding this comment.
Maybe you could move this to a Controller to avoid overloading the routes file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept to implement https://github.com/Yoast/YoastSEO.js
I had some trouble compiling the SCSS from the package, so copied that manually.
Not sure how to best integrate this. It's a lot more extensive, but that needs the 'article content' of the page, which I'm not sure how to detect.
In the current form, you can just go to
kupo.app/snippet?url=http://mysite.comand get the preview from the snippet.Also, compiling with yarn doesn't work, only in watch mode :/ Due to error in YoastSEO