Refactor decoder #24
Merged
Refactor decoder #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced iterable as the return type for decoders to allow for more flexible data structures, moving away from strict arrays. This allows the use of generators for on-demand data processing. Added a `MapperInterface` for transforming responses into objects, facilitating object-oriented handling of response data. Streamlined the creation of default decoders by defining `ChainDecoder::default` to reduce redundancy and ensure consistency across usage. A new `GenericMapper` allows custom mapping functions, providing clients with customizable response handling strategies. Additionally, `Response` now implements `JsonSerializable`, offering a standardized way to convert response data to JSON.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
============================================
+ Coverage 84.77% 85.12% +0.35%
- Complexity 313 326 +13
============================================
Files 38 39 +1
Lines 729 753 +24
============================================
+ Hits 618 641 +23
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
jenky
force-pushed
the
refactor-decoder
branch
from
227ede2
to
38afe73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
iterableas the new return type for decoders to allow for more flexible data structures, moving away from strict arrays. This allows the use of generators for on-demand data processing (cerbero/lazy-json, Laravel Lazy Collection), resulting in improved performance and reduced memory consumption when parsing large response bodies.$response->decode(): iterableis nowpublicinstead ofprivateto return the original value of the decoder.Furthermore, decoders can implement the
MapperInterface, allowing for the transformation of response bodies into objects. This facilitates object-oriented handling of response data using Data Transfer Objects (DTOs) or Value Objects (VOs). To retrieve your object, uses$response->object().