Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for roave/backward-compatibility-check #80

Closed
wants to merge 1 commit into from
Closed

Add metadata for roave/backward-compatibility-check #80

wants to merge 1 commit into from

Conversation

sebastianbergmann
Copy link
Member

@sebastianbergmann sebastianbergmann commented Jun 15, 2020

This makes it possible to install Roave/BackwardCompatibilityCheck using Phive.

@sebastianbergmann
Copy link
Member Author

CC @asgrim @Ocramius

@theseer
Copy link
Member

theseer commented Jun 15, 2020

Is that really the alias you want to have? ;-)

@theseer
Copy link
Member

theseer commented Jun 15, 2020

And, to nit-pick on the wording: you can install it without an alias if you use github releases...

@theseer
Copy link
Member

theseer commented Jun 15, 2020

There's not signature for the release phar.
We only support aliases for signed releases.

@sebastianbergmann
Copy link
Member Author

I made the changes proposed here locally in my ~/.phive/repositories.xml. Then phive install --force-accept-unsigned backward-compatibility-check worked.

Feel free to close this pull request if I did something wrong. I just want to be able to install/update the PHAR of roave/backward-compatibility-check using Phive.

@theseer
Copy link
Member

theseer commented Jun 15, 2020

You didn't do anything wrong. It technically works just fine.

It's a political decision to not (publicly) allow aliases for unsigned releases.

@sebastianbergmann
Copy link
Member Author

I just realized that an alias (aka. addition to repositories.xml) is not required:

$ phive install Roave/BackwardCompatibilityCheck                        
Phive 0.14.2 - Copyright (C) 2015-2020 by Arne Blankerts, Sebastian Heuer and Contributors
Downloading https://api.github.com/rate_limit
[WARNING]  roave/backwardcompatibilitycheck 4.4.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 4.3.0: No downloadable PHAR 
[WARNING]  roave/backwardcompatibilitycheck 4.2.1: No downloadable PHAR 
[WARNING]  roave/backwardcompatibilitycheck 4.2.0: No downloadable PHAR 
[WARNING]  roave/backwardcompatibilitycheck 4.1.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 4.0.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 3.0.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 2.1.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 2.0.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 1.1.1: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 1.1.0: No GPG Signature 
[WARNING]  roave/backwardcompatibilitycheck 1.0.3: No downloadable PHAR 
[WARNING]  roave/backwardcompatibilitycheck 1.0.2: No downloadable PHAR 
[WARNING]  roave/backwardcompatibilitycheck 1.0.1: No downloadable PHAR 
[WARNING]  roave/backwardcompatibilitycheck 1.0.0: No downloadable PHAR 
[ERROR]    No matching release found! 
$ phive install --force-accept-unsigned Roave/BackwardCompatibilityCheck
Phive 0.14.2 - Copyright (C) 2015-2020 by Arne Blankerts, Sebastian Heuer and Contributors
Downloading https://api.github.com/rate_limit
Downloading https://github.com/Roave/BackwardCompatibilityCheck/releases/download/4.4.0/roave-backward-compatibility-check.phar
[ERROR]    Cannot write phar to /home/sb/.phive/phars/roave 

I will close this pull request now, sorry for the noise. However, Cannot write phar to /home/sb/.phive/phars/roave looks like a bug to me.

@sebastianbergmann sebastianbergmann deleted the backward-compatibility-check branch June 15, 2020 15:36
Copy link

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know what aliases are in phive 🤷

@sebastianbergmann
Copy link
Member Author

@Ocramius The only thing you need to worry about is Roave/BackwardCompatibilityCheck#244 😄

@theseer
Copy link
Member

theseer commented Jun 15, 2020

It's a means to support a) short names (like, say, phpdoc rather than having to use phpdocumentor/phpdocumentor) when installing and b) allow non-standard locations to get phars from (phpunit to get it from phar.phpunit.de)

@theseer
Copy link
Member

theseer commented Jun 15, 2020

[ERROR] Cannot write phar to /home/sb/.phive/phars/roave


I will close this pull request now, sorry for the noise. However, `Cannot write phar to /home/sb/.phive/phars/roave` looks like a bug to me.

You want to upgrade to 0.14.4. That was bug phar-io/phive#262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants