Skip to content

true branch not executed #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

true branch not executed #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
665a496
dead code
fouziray Sep 17, 2025
4036e7d
Merge a7c8a0bba9811ebeaaf5c4fd6acfef199ef8d2a9
fouziray Sep 17, 2025
87b96d6
use stacktop and giving name to the return
fouziray Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions smalltalksrc/VMMaker/CoInterpreter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,8 +1564,11 @@ CoInterpreter >> ceSend: selector super: superNormalBar to: rcvr numArgs: numArg
methodOperand: (self mnuMethodOrNilFor: rcvr)
numArgs: argumentCount) asUnsignedInteger
> cogit minCogMethodAddress]) ifTrue:
[cogit
linkSendAt: (stackPages longAt: stackPointer)
[
|outerReturn|
outerReturn := self stackTop.
cogit
linkSendAt: outerReturn
in: (self mframeHomeMethod: framePointer)
to: cogMethod
offset: (superNormalBar = 0
Expand All @@ -1588,8 +1591,11 @@ CoInterpreter >> ceSend: selector super: superNormalBar to: rcvr numArgs: numArg
[:newCogMethod| cogMethod := newCogMethod]]].
cogMethod selector = selector
ifTrue:
[cogit
linkSendAt: (stackPages longAt: stackPointer)
[
|outerReturn|
outerReturn := self stackTop.
cogit
linkSendAt: outerReturn
in: (self mframeHomeMethod: framePointer)
to: cogMethod
offset: (superNormalBar = 0
Expand Down
8 changes: 4 additions & 4 deletions smalltalksrc/VMMaker/CogInLineLiteralsARMCompiler.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ CogInLineLiteralsARMCompiler >> rewriteInlineCacheAt: callSiteReturnAddress tag:
<var: #callSiteReturnAddress type: #usqInt>
<var: #callTargetAddress type: #usqInt>
| call callDistance |
false
ifTrue: [self assert: callTargetAddress >= cogit minCallAddress]
ifFalse: [callTargetAddress >= cogit minCallAddress ifFalse:
[self error: 'linking callsite to invalid address']].

callTargetAddress >= cogit minCallAddress ifFalse:
[self error: 'linking callsite to invalid address'].

callDistance := (callTargetAddress - (callSiteReturnAddress + 8 "pc offset"- 4 "return offset")) signedIntToLong.
self assert: (self isInImmediateJumpRange: callDistance). "we don't support long call updates here"
call := self bl: callDistance.
Expand Down