Skip to content

Conversation

JMLF
Copy link

@JMLF JMLF commented Jul 25, 2025

We set the submit callback when it's needed otherwise we unset it.

We tried changing the submit callback from the code presenter but calling whenSubmitDo: multiple times has side effects and raises an exception after the first time.

Instead what we do is :

  • When a result is selected, the result stores the corresponding callback in itself (each result items has it own rules).
  • We have a single submit callback in the code presenter.
  • When the submit callback triggers we delegate to the result.

@Ducasse Ducasse requested a review from estebanlm August 1, 2025 09:52
Copy link
Member

@estebanlm estebanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay ;)

@estebanlm estebanlm merged commit 963fca8 into pharo-spec:Pharo14 Sep 1, 2025
1 of 2 checks passed
@MarcusDenker MarcusDenker changed the title Fix #1140. Fix #1140: [Finder] Feature request: Allow saving edited method code Sep 5, 2025
@MarcusDenker
Copy link
Contributor

Note: I change the title to be better for the Friday mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants