-
-
Notifications
You must be signed in to change notification settings - Fork 148
Partial: Avenge #6994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Partial: Avenge #6994
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7972b8d
Partial: Avenge
JacobWoodson e9174a6
Merge remote-tracking branch 'origin/main' into pr/6994
matthewevans 8386cfb
fix(PR-6994): retain departed attack history through turn boundary
matthewevans d021e59
fix(PR-6994): keep attack history off GameState stack
matthewevans bf5e374
test(PR-6994): cover boxed attack history state
matthewevans 48ca248
Merge remote-tracking branch 'origin/main' into pr6994-refresh-bf5e374e
matthewevans 67d51ff
fix(PR-6994): canonicalize attack history serialization
matthewevans 3198d9a
test(PR-6994): update serde adapter census
matthewevans 6ab4ce9
Merge remote-tracking branch 'origin/main' into pr/6994
matthewevans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Test the parsed Avenge path before merge.
Lines 3167-3176 construct
StaticDefinition::ModifyCostandStaticCondition::AnyPlayerAttackedYouLastTurndirectly. The documented coverage audit still reports that parsed Avenge cost reduction is unsupported because lowering swallows the condition. This test passes while the real Oracle card remains unsupported.Route the parsed condition into the real cost modifier. Add an end-to-end test that parses Avenge Oracle text and prepares the spell cast.
🤖 Prompt for AI Agents
Source: Path instructions