chore(ai): restamp the perf baseline's card-data hash for the scoped provenance - #7027
Merged
Merged
Conversation
…provenance #7013 changed `card_data_hash` from a whole-file digest of card-data.json to a digest of only the cards `default_scenarios()` actually plays (46 of 46, as CI reports). The committed baseline still carries the OLD whole-file value, so the two sides are produced by different functions and can never agree — every perf gate run since the merge prints note: card-data hash changed (e2db8a6d…→d11502ce…) — likely a card-data-driven trajectory shift, not a cost-per-node regression on an unchanged workload. A diagnostic that fires unconditionally is worse than none: the next reader sees "card-data changed" and stops investigating a real regression. The new value is the one the merged binary computes on the CI runner, observed identically on two separate runs against different weekly card pools (30963718102 pre-merge, 30996886019 post-merge) — consistent with the scoped subset being stable across MTGJSON vintages, which is what motivated #7013. Provenance only. Counters, seed, action_cap, sample_count and scenarios are untouched, so this changes no PASS/FAIL verdict — `card_data_hash` is diagnostic and never feeds `any_fail()`. NOT fixed here, and worth its own change: `git_sha` reads 64b65e5, a pull/6777 BRANCH head that was never on main. Measuring at that commit yields layers_full_eval=4045 against the 3495 recorded here, so the baseline's counters do not reproduce at the commit they name. Restamping the SHA without re-measuring would only move the inconsistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7013 changed
card_data_hashfrom a whole-file digest of card-data.json to adigest of only the cards
default_scenarios()actually plays (46 of 46, as CIreports). The committed baseline still carries the OLD whole-file value, so the
two sides are produced by different functions and can never agree — every perf
gate run since the merge prints
note: card-data hash changed (e2db8a6d…→d11502ce…) — likely a card-data-driven
trajectory shift, not a cost-per-node regression
on an unchanged workload. A diagnostic that fires unconditionally is worse than
none: the next reader sees "card-data changed" and stops investigating a real
regression.
The new value is the one the merged binary computes on the CI runner, observed
identically on two separate runs against different weekly card pools
(30963718102 pre-merge, 30996886019 post-merge) — consistent with the scoped
subset being stable across MTGJSON vintages, which is what motivated #7013.
Provenance only. Counters, seed, action_cap, sample_count and scenarios are
untouched, so this changes no PASS/FAIL verdict —
card_data_hashisdiagnostic and never feeds
any_fail().NOT fixed here, and worth its own change:
git_shareads 64b65e5, apull/6777 BRANCH head that was never on main. Measuring at that commit yields
layers_full_eval=4045 against the 3495 recorded here, so the baseline's counters
do not reproduce at the commit they name. Restamping the SHA without
re-measuring would only move the inconsistency.