Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed: Followed actual implementation. #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed: Followed actual implementation. #83

wants to merge 1 commit into from

Conversation

t-matsudate
Copy link

@t-matsudate t-matsudate commented Jul 27, 2024 •
edited
Loading

This change corresponds to phel-lang/phel-lang#725

@t-matsudate t-matsudate mentioned this pull request Jul 27, 2024
Open
@Chemaclass
Copy link
Member

Can you write an automated phel test showing that the code works this way as well, please?

@t-matsudate
Copy link
Author

@Chemaclass Sorry! Which repository should I write? Is it ok in phel-lang/phel-lang?

@t-matsudate
Copy link
Author

I wrote those tests.
phel-lang/phel-lang#740

@Chemaclass
Copy link
Member

@jenshaase what do you think about this?

@jenshaase
Copy link
Member

@Chemaclass I added my comment in the ticket: phel-lang/phel-lang#725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeghead smeghead smeghead approved these changes

@jenshaase jenshaase Awaiting requested review from jenshaase

@Chemaclass Chemaclass Awaiting requested review from Chemaclass

Assignees

@t-matsudate t-matsudate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-matsudate @Chemaclass @jenshaase @smeghead