Update testing.md #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First paragraph had reference to possibly deprecated info. Second paragraph was definitely out of date looking the [current sources](https://github.com/phel-lang/phel-lang/blob/001699edd91c417c646d45b8ac46d3128de4a2d8/src/phel/test.phel#L327). Rewrote it also so it is at least slightly more correct and without typos while some improvement could be made in it's usage with REPL etc.
|
On second note, while testing Not sure if it's a bug or if it's unfinished or something, but haven't faced similar behavior with Clojure. |
|
Nice catch. This was not up-to-date, as this phel function was created mainly to be used on the TestCommand which execute the phel tests:
As you can see, the first argument is definitely a hash-map of options and then the namespaces, your suggestion is correct. |
Chemaclass
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First paragraph had reference to possibly deprecated info.
Second paragraph was definitely out of date looking the current sources. Rewrote it also so it is at least slightly more correct and without typos while some improvement could be made in it's usage with REPL etc.