feat(pdo): statement-level get/set-attribute via polymorphic dispatch#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
PDOStatement::getAttribute/setAttribute. Rather than introduce new names that collide with the connection-level accessors in the singlephel.pdonamespace,get-attribute/set-attributenow dispatch on the handle (per the option suggested in #12):A private
attr-targethelper resolves:pdovs:stmtfrom the struct type (statement?), keeping both accessors a one-liner.(declare statement?)added before the(load "pdo/statement")so the predicate resolves cross-file.Note on the test driver
Statement attributes are driver-specific. SQLite (the test driver) doesn't support them:
getAttributeraisesIM001andsetAttributeis a no-op returningfalse. The tests therefore prove routing - that the statement branch reaches thePDOStatement(observable via the\PDOException) while the connection branch keeps returning values. The wrapper is fully functional for drivers that support statement attributes (e.g. MySQL).src/pdo/statement.phel.set-attribute-dispatches-to-statement,get-attribute-dispatches-to-statement(connection + statement branches). Existingattribute-roundtripstill green.### Changed) updated.Polish pass: extracted
attr-targetto remove the get/set duplication.composer testgreen (41 assertions).Closes #12